Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

samples: Add radio trims and PAN for nRF54H20 in DTM, RT and ESB #19878

Merged
merged 1 commit into from
Jan 14, 2025
Merged

samples: Add radio trims and PAN for nRF54H20 in DTM, RT and ESB #19878

merged 1 commit into from
Jan 14, 2025
+183 −8

Conversation

grochu
Copy link
Contributor

@grochu grochu commented Jan 13, 2025

Loading trim values and adding PAN workarounds in the Radio registers will improve RF performance. PANs implemented: HMPAN-18, HMPAN-103.

Ref. NCSDK-31274

@grochu grochu requested review from lemrey and a team as code owners January 13, 2025 14:03
@github-actions github-actions bot added the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Jan 13, 2025
@grochu grochu requested a review from dchat-nordic January 13, 2025 14:03
@NordicBuilder
Copy link
Contributor

NordicBuilder commented Jan 13, 2025 •
edited
Loading

CI Information

To view the history of this post, clich the 'edited' button above
Build number: 3

Inputs:

Sources:

sdk-nrf: PR head: 8305c88813a7d1e91e0dc56254d6eb0b1c75370c

more details

sdk-nrf:

PR head: 8305c88813a7d1e91e0dc56254d6eb0b1c75370c
merge base: 919489e74c78bc14fed7627070e45dc7f53b0b02
target head (main): f38d3119502c014935538628b3305009dd0697ff
Diff

Github labels

Enabled Name Description
ci-disabled Disable the ci execution
ci-all-test Run all of ci, no test spec filtering will be done
ci-force-downstream Force execution of downstream even if twister fails
ci-run-twister Force run twister
ci-run-zephyr-twister Force run zephyr twister
List of changed files detected by CI (4) 
doc
│  ├── nrf
│  │  ├── releases_and_maturity
│  │  │  ├── releases
│  │  │  │  │ release-notes-changelog.rst
samples
│  ├── bluetooth
│  │  ├── direct_test_mode
│  │  │  ├── src
│  │  │  │  │ dtm.c
│  ├── peripheral
│  │  ├── radio_test
│  │  │  ├── src
│  │  │  │  │ main.c
subsys
│  ├── esb
│  │  │ esb.c

Outputs:

Toolchain

Version: 11349092be
Build docker image: docker-dtr.nordicsemi.no/sw-production/ncs-build:11349092be_912848a074

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

  • ◻️ Toolchain - Skipped: existing toolchain is used
  • ✅ Build twister
    • sdk-nrf test count: 535
  • ✅ Integration tests
    • ✅ test-fw-nrfconnect-ble_samples
    • ⚠️ test-fw-nrfconnect-proprietary_esb
Disabled integration tests
    • desktop52_verification
    • doc-internal
    • test_ble_nrf_config
    • test-fw-nrfconnect-apps
    • test-fw-nrfconnect-ble_mesh
    • test-fw-nrfconnect-boot
    • test-fw-nrfconnect-chip
    • test-fw-nrfconnect-fem
    • test-fw-nrfconnect-nfc
    • test-fw-nrfconnect-nrf-iot_libmodem-nrf
    • test-fw-nrfconnect-nrf-iot_mosh
    • test-fw-nrfconnect-nrf-iot_nrf_provisioning
    • test-fw-nrfconnect-nrf-iot_positioning
    • test-fw-nrfconnect-nrf-iot_samples
    • test-fw-nrfconnect-nrf-iot_serial_lte_modem
    • test-fw-nrfconnect-nrf-iot_thingy91
    • test-fw-nrfconnect-nrf-iot_zephyr_lwm2m
    • test-fw-nrfconnect-nrf_crypto
    • test-fw-nrfconnect-ps
    • test-fw-nrfconnect-rpc
    • test-fw-nrfconnect-rs
    • test-fw-nrfconnect-tfm
    • test-fw-nrfconnect-thread
    • test-fw-nrfconnect-zigbee
    • test-low-level
    • test-sdk-audio
    • test-sdk-dfu
    • test-sdk-find-my
    • test-sdk-mcuboot
    • test-sdk-pmic-samples
    • test-sdk-sidewalk
    • test-sdk-wifi
    • test-secdom-samples-public

Note: This message is automatically posted and updated by the CI

@grochu grochu force-pushed the dtm_rt_nrf54h20_radio_pan branch from 7840728 to 98457b4 Compare January 14, 2025 09:27
@grochu grochu requested a review from a team as a code owner January 14, 2025 09:27
@github-actions github-actions bot added doc-required PR must not be merged without tech writer approval. and removed changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. labels Jan 14, 2025
@grochu grochu requested a review from peknis January 14, 2025 09:28
@grochu
Copy link
Contributor Author

grochu commented Jan 14, 2025

I added changelog entries, that were requested outside of this review.

@NordicBuilder
Copy link
Contributor

You can find the documentation preview for this PR at this link.

Note: This comment is automatically posted by the Documentation Publish GitHub Action.

peknis
peknis requested changes Jan 14, 2025
View reviewed changes
doc/nrf/releases_and_maturity/releases/release-notes-changelog.rst Outdated
@@ -124,7 +124,7 @@ DECT NR+
Enhanced ShockBurst (ESB)
-------------------------

|no_changes_yet_note|
* Added loading of radio trims and a fix of HW errata for the nRF54H20 SoC to improve the RF performance.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* Added loading of radio trims and a fix of HW errata for the nRF54H20 SoC to improve the RF performance.
* Added loading of radio trims and a fix of a hardware errata for the nRF54H20 SoC to improve the RF performance.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same for other instances.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@grochu
samples: Add radio trims and PAN for nRF54H20 in DTM, RT and ESB
8305c88 
Loading trim values and adding PAN workarounds in the Radio registers
will improve RF performance. PANs implemented: HMPAN-18, HMPAN-103.

Ref. NCSDK-31274

Signed-off-by: Michał Grochala <[email protected]>
@grochu grochu force-pushed the dtm_rt_nrf54h20_radio_pan branch from 98457b4 to 8305c88 Compare January 14, 2025 10:14
@carlescufi carlescufi merged commit 693d1ff into nrfconnect:main Jan 14, 2025
13 checks passed
@NordicBuilder NordicBuilder mentioned this pull request Jan 17, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@divipillai divipillai divipillai approved these changes

@dchat-nordic dchat-nordic dchat-nordic approved these changes

@maje-emb maje-emb maje-emb approved these changes

@peknis peknis peknis approved these changes

@carlescufi carlescufi carlescufi approved these changes

@pdunaj pdunaj pdunaj approved these changes

@lemrey lemrey Awaiting requested review from lemrey lemrey is a code owner

Assignees
No one assigned
Labels
backport v2.9-nRF54H20-branch doc-required PR must not be merged without tech writer approval.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@grochu @NordicBuilder @pdunaj @carlescufi @peknis @maje-emb @dchat-nordic @divipillai